This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Added secret debug menu preference to override the push server URL ( #24170) #26667
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
server override prefs. They were taking a lot of screen space on the top-level settings menu as individual items
Here's my attempt to describe the UI:
I couldn't think of a good way to unit test this, but I tested this with a dev build of Fenix, using the keys from
fenix_firebase.xml
and a-c#12687 and sending a tab seemed to work. I added some debugging in app-services, so you should be able to double check the push server URL by withadb logcat | grep push
(once a-c picks up a new a-s release). The log line will look like this:I believe the firebase keys built into release builds will work with an overridden push server, but I'm not sure. Can someone who understands this better than me confirm this?
Pull Request checklist
QA
To download an APK when reviewing a PR (after all CI tasks finished running):
Checks
at the top of the PR page.firefoxci-taskcluster
group on the left to expand all tasks.build-debug
task.View task in Taskcluster
in the newDETAILS
section.GitHub Automation
Fixes #24170